Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OS X build-from-source doc to using Qt6 by default #2800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gudauu
Copy link

@Gudauu Gudauu commented Aug 4, 2024

Reason for this PR:

  • The current OS X build dependency specified in the Homebrew formulae defaults to Qt6 instead of Qt5. Therefore, Qt6 should be used as the default in CMake commands and docs.

What changed:

  • In CMakeLists.txt, change WITH_QT6 to ON.
  • Update the OS X build-from-source docs accordingly.

Tests:

  • Tested on macOS 14.5; the build succeeded without problem.

Behaviour before this change:

  • Followed docs precisely, build failed at the CMake stage with error: “Could not find a package configuration file provided by Qt5Widgets.”

@Gudauu Gudauu requested a review from hluk as a code owner August 4, 2024 17:40
@@ -43,7 +43,7 @@ endif()

set(CMAKE_AUTOMOC ON)

OPTION(WITH_QT6 "Enable Qt 6" OFF)
OPTION(WITH_QT6 "Enable Qt 6" ON)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes using Qt 6 by default everywhere and would break a couple of builds for Linux distros.

Would it be possible to make this automatic? Specifically:

  • By default if the option is not overridden, pick Qt 6 preferably and if not found fallback to Qt 5.
  • If set to ON by user, require Qt 6.
  • If set to OFF by user, require Qt 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants