PUB-2588 Add List Type For Court Subscription #1348
Conversation
| {% extends "template.njk" %} | ||
| {% from "./macros/common-components.njk" import goBack, submitButton %} | ||
| {%- from "govuk/components/checkboxes/macro.njk" import govukCheckboxes -%} | ||
| {%- from "govuk/components/input/macro.njk" import govukInput -%} |
There was a problem hiding this comment.
if govukCheckboxes and govukInput nunjucks macro are not used we can remove them here
| {% endblock %} | ||
|
|
||
| {% block beforeContent %} | ||
| {{ govukBackLink({ |
There was a problem hiding this comment.
Can we not use the goBack() macro defined in common-components here?
There was a problem hiding this comment.
as discussed, updated.
| "removeText": "Remove", | ||
| "table": { | ||
| "header1": "Case name", | ||
| "header2": "Party name(s)", | ||
| "header3": "Reference number", | ||
| "header4": "Actions" | ||
| }, | ||
| "buttonText_court_subscription": "Continue", |
There was a problem hiding this comment.
title_court_subscription and buttonText_court_subscription need to be added to the welsh language resource too
src/main/service/LocationService.ts
Outdated
| @@ -99,4 +99,14 @@ export class LocationService { | |||
| public async deleteLocationById(locationId: number, requester: string): Promise<object> { | |||
| return await locationRequest.deleteCourt(locationId, requester); | |||
| } | |||
|
|
|||
| public async findCourtsJurisdiction(locations): Promise<object> { | |||
There was a problem hiding this comment.
Can we change the returned type to Promise<string[]> and not object?
There was a problem hiding this comment.
done, thanks, good catch :)
| @@ -282,6 +282,17 @@ export default function (app: Application): void { | |||
| isPermittedMedia, | |||
| app.locals.container.cradle.subscriptionManagementController.get | |||
| ); | |||
| app.get('/subscription-add-list', isPermittedMedia, app.locals.container.cradle.subscriptionAddListController.get); | |||
There was a problem hiding this comment.
We need to add new a11y tests for the new routes too
|
JIRA link
https://tools.hmcts.net/jira/browse/
Change description
Add List Type For Court Subscription
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No