Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gcp dataproc clusters #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

blentz
Copy link
Contributor

@blentz blentz commented Jul 26, 2021

This PR is adding support for scanning GCP's Dataproc Clusters. [1]

This enables all of the filters that work for Instances to also work for dataproc Clusters.

[1] https://cloud.google.com/dataproc/

Copy link
Contributor

@mhmxs mhmxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. The change looks really good.

gcp/gcp.go Outdated Show resolved Hide resolved
gcp/gcp.go Outdated Show resolved Hide resolved
gcp/gcp.go Outdated Show resolved Hide resolved
operation/common.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
blentz and others added 3 commits November 18, 2022 09:58
Bump go version to 1.17
Introduce new resource type: storage
Introduce new action: cleanup
Introduce new env var configuration: RETENTION_DAYS
Collect Azure storage accounts, filter its blob contents by creation date, and delete old blobs.
@blentz blentz force-pushed the support_dataproc_clusters branch 7 times, most recently from bca66de to 00d4a7b Compare November 18, 2022 15:39
@blentz
Copy link
Contributor Author

blentz commented Nov 18, 2022

@mhmxs Sorry for the delay in addressing the review comments. I believe I've fixed everything that was mentioned. :)

@mhmxs
Copy link
Contributor

mhmxs commented Nov 21, 2022

@blentz Thank you. I think yes. so LGFM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants