wrap xattr IO functions with DCOPY_USE_XATTRS #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calls to these functions and the imports are wrapped with DCOPY_USE_XATTRS so also wrap the mfu_ function definitions since if the system library is not included, the sys functions are not defined. Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
|
@Michael-Hennecke Will you give this a try? It should work for both |
ofaaland
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Hi @daltonbohning thanks for this fix. I have just one question.
Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
|
Thanks @ofaaland. Okay if I merge this? I use to run them by Adam but not sure what the process is now. (I do have perms to merge) |
carbonneau1
approved these changes
Nov 5, 2024
Sounds good, thanks.
Good point, we should discuss a process. @carbonneau1 here at LLNL has agreed to take over mpifileutils maintenance, but is just getting started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calls to these functions and the imports are wrapped with DCOPY_USE_XATTRS so also wrap the mfu_ function definitions since if the system library is not included, the sys functions are not defined.
Resolves #578