Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions new #46

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Sessions new #46

wants to merge 38 commits into from

Commits on May 25, 2021

  1. add support for sessions

    Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hjelmn authored and hppritcha committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2dbf192 View commit details
    Browse the repository at this point in the history
  2. sessions: temporarily disable fboxes

    the way fboxes works has issues for the sessions implementation,
    in particular tthe session finalize approach.
    
    what happens without this temporary fix is that if there is not some fully shcnronizing call
    prior to calling session_finalize, there are cases where a process may be probing its fast
    mailboxes for processes that are tearing down theses fboxes.  That results in segfauls and
    sigbus problems.
    
    The fast box mechanism will need to be supplemented with some kind of shutdown mechanism
    that will tell the owner of the fboxes when its okay to actually tear them down.
    
    IN the interest of making progress using the sessions prototype with applications, shut
    down the fbox process for the prototype and return to coming up with a real fix at a later
    date.
    
    relates to #3
    
    drop use of MPI_Flag
    
    what we're reading at the forum now for Sessions proposal has ditched MPI_Flags.
    Now using info object to MPI_Session_init to specify thread support level
    desired.
    
    Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
    hppritcha committed May 25, 2021
    Configuration menu
    Copy the full SHA
    257de81 View commit details
    Browse the repository at this point in the history
  3. sessions: update to new API changes

    and so much more
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed May 25, 2021
    Configuration menu
    Copy the full SHA
    62dd7d5 View commit details
    Browse the repository at this point in the history
  4. OFI: add support for exCID

    Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
    tomhers authored and hppritcha committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6e7acea View commit details
    Browse the repository at this point in the history
  5. sessions: various fixes

    remove extraneous method
    add patch to bypass excid exchange
    some fixes to excid bypass path
    sessions/fortran: add missing redefine for profiling interfaces
    
    sessions: move ompi_mpi_instance_cleanup_pml ahead in cleanup
    stack to avoid melt-downs in ompi_win_finalize, etc. under certain
    cases.
    
    fix attr subsys and ucx compile errors
    
    swat uninitialized variables
    
    fixes many test failures when not using --enable-debug and
    application calling MPI_Comm_create_errhandler, etc.
    
    sessions: put MPI_Intercomm_merge back to orig
    
    don't use MPI_Comm_create_from_group since its not supported
    by all PMLs.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    tomhers authored and hppritcha committed May 25, 2021
    Configuration menu
    Copy the full SHA
    10059ea View commit details
    Browse the repository at this point in the history
  6. sesssions: rebase over ULFM

    minor patchups
    
    sessions: rebase over ULFM attributes
    patch up to adjust for MPI_FT key
    
    sessions:  remove pmix glue functions
    for PMIx group operations.  Now calling pmix directly
    
    sessions: adjustment for ucx initialization
    
    since it makes calls to hwloc at this point which needs
    PMIx and hence rte_init to have been called.
    
    sessions: rebase over ULFM OB1 changes
    
    sessions: rebase over ULFM portals adjustments
    
    sessions: rebase over ULFM minor ucx fixup
    
    sessions: rebase over ULFM changes to FT code
    
    ucx: improve configury
    
    to handle case of HAVE_UCP_ATTR_MEMORY_TYPES not defined
    
    remove redundeant check for gni provier
    
    remove some commented out print statements
    
    Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
    hppritcha committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3f5fbc6 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. sessions: rebase fixup

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed May 27, 2021
    Configuration menu
    Copy the full SHA
    505bb88 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. openpmix:update sha to pick up reinit fixes

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    d194ecd View commit details
    Browse the repository at this point in the history
  2. sessions: release datatypes without checking cookie

    Turns out that the predefined datatypes are initialized statically,
    so the first time through calling ompi_datatype_finalize the magic
    cookie gets cleared if code is compiled in debug mode.  This results
    in a second call to ompi_datatype_finalize to blow up with an assert
    since the cookie had been cleared in the first pass.
    
    Add a new OBJ_DESTRUCT variant which does not check/clear cookie even
    when the code is compiled in --enable-debug mode.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    cd67fe2 View commit details
    Browse the repository at this point in the history
  3. sessions: fix another problem with finalize

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    13149a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. sessions: fix problems with reinit of bml

    this patch fixes problems encountered trying to
    handle session_init following a previous finalize
    that shut down the bml.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    00f6e0e View commit details
    Browse the repository at this point in the history
  2. sessions: remove a debug print statement

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b2df2ad View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. sessions: do not finalize common till

    ompi_mmpi_instance_unit_basic_count will drop to zero with the
    next call to ompi_mpi_instance_release.
    
    This patch may need a better solution.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    6f1b63e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. sessions: do not clean up predefined datatypes

    this leads to meltdowns in a new session is inited as
    the predefined datatypes have been destructed.
    
    Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
    hppritcha committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    9c7a415 View commit details
    Browse the repository at this point in the history
  2. sessions: undo hack to finalize common

    The fix to not destruct the predefined datatypes seem to have
    addressed the problem.  This commit removes the hack patch.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2ad7830 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. sessions: switch to using mpi_max_stringtag_len

    per the MPI 4.0 standard
    
    related to
    
    #37
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    23c5c0d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. undo changes to ring_c.c

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    30f7a1c View commit details
    Browse the repository at this point in the history
  2. put back changes to a comment from master

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    94b502d View commit details
    Browse the repository at this point in the history
  3. remove sleepy barrier stuff

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    ac6e70c View commit details
    Browse the repository at this point in the history
  4. sessions: remove MPI_File_open_from_group

    this didn't make it into the MPI 4.0 standard
    
    related to #52
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    e1e6111 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. sessions: remove sessions attr related funcs

    forum decided attrs had enough problems already and shouldn't be
    extended to other mpi objects, so sessions attrs are not part
    of the MPI 4.0 standard
    
    related to #47
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    d01b1d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Configuration menu
    Copy the full SHA
    a035ac0 View commit details
    Browse the repository at this point in the history
  2. sessions: fix up win errhandler create return

    processing to match with current master.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    5342b31 View commit details
    Browse the repository at this point in the history
  3. sessions: remove sessions attribute type

    remove sessions (instance) attribute type a this is not part of the MPI 4.0 standard.
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    7730c47 View commit details
    Browse the repository at this point in the history
  4. add a missing copyright

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    72157e5 View commit details
    Browse the repository at this point in the history
  5. sessions: remove unnecessary lines

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    fabdf72 View commit details
    Browse the repository at this point in the history
  6. sessions: fix for instance on comm tracking

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    1a428ce View commit details
    Browse the repository at this point in the history
  7. sessions: use ompi_errhandler_invoke for ERR_INIT

    check
    
    related to #49
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    1a46303 View commit details
    Browse the repository at this point in the history
  8. relates to #50

    tomhers committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    1336178 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dec89cd View commit details
    Browse the repository at this point in the history
  10. sessions: remove mpi_win_create_from_group

    this was not part of the MPI 4.0 standard
    
    related to #54
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    f3cbf36 View commit details
    Browse the repository at this point in the history
  11. sessions: remove left over pmix file

    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    503e335 View commit details
    Browse the repository at this point in the history
  12. sessions: remove win_allocate_shared_from_group

    not part of the MPI 4 standard so removing
    
    related to #54
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    0eed666 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. sessions: remove topo from group related funcs

    and some more windows from group stuff too.
    
    None of these made it into the sessions API for MPI 4.0 and its very
    likely they will be added in a MPI 5.0 release.  Other approaches to topology
    constructs outside of sessions proposal are being explored.
    
    Related to  #58
    Related to #54
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    fdd5bab View commit details
    Browse the repository at this point in the history
  2. sessions: use global cid alloc algorithm

    for ULFM communicators.
    
    Related to #43
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    12127fa View commit details
    Browse the repository at this point in the history
  3. sessions: handle error better in fortran

    comm_create_from_group
    
    and
    
    intercomm_create_from_groups
    
    related to #56
    
    Signed-off-by: Howard Pritchard <howardp@lanl.gov>
    hppritcha committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    4c110d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. fix pset_name handling

    Signed-off-by: tomhers <tom.herschberg@gmail.com>
    tomhers committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    40d959b View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. add instance check to functions with arrays of requests

    Signed-off-by: tomhers <tom.herschberg@gmail.com>
    tomhers committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    7db5a88 View commit details
    Browse the repository at this point in the history