Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added output format options for --help #180

Merged
merged 14 commits into from
Aug 7, 2015
Merged

Conversation

Caylo
Copy link
Contributor

@Caylo Caylo commented Aug 5, 2015

No description provided.

@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

@stdweird
Copy link
Member

stdweird commented Aug 5, 2015

@Caylo unittests required to get this merged

# along with vsc-base. If not, see <http://www.gnu.org/licenses/>.
# #
"""
A class that has some support functions for generating rst documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a class, just remove the whole A class that has some support part

@boegel
Copy link
Member

boegel commented Aug 5, 2015

Jenkins: ok to test

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/298/
Test FAILed.

@@ -222,7 +223,13 @@ def take_action(self, action, dest, opt, value, values, parser):
"""Extended take_action"""
orig_action = action # keep copy

if action == 'shorthelp':
# dest is None for actions like shorthelp and confighelp
if dest and getattr(parser._long_opt.get('--'+dest, ''), 'store_or', '') == 'formathelp':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic string formathelp, add a constant for this (or for help)

@boegel
Copy link
Member

boegel commented Aug 5, 2015

@Caylo: Caylo#1

extend unit tests, bump version, minor fixes
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/299/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/300/
Test PASSed (test).

titles = [t]

# small table
table = '\n'.join(mk_rst_table(titles, entries))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the '\n'.join in both, it adds nothing to the assertEqual

minor style changes in docs.py
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/302/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/303/
Test PASSed (test).

from vsc.utils.fancylogger import getLogger, setLogLevel, getDetailsLogLevels
from vsc.utils.missing import shell_quote, nub
from vsc.utils.optcomplete import autocomplete, CompleterOption


HELP_OUTPUTOPTIONS = ['', 'rst', 'short', 'config',]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename + drop trailing ,

HELP_OUTPUT_FORMAT_OPTIONS = ['', 'rst', 'short', 'config']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or better: HELP_OUTPUT_FORMATS

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/304/
Test FAILed.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/305/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/306/
Test PASSed (test).

enhance tests for help options
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/vsc-base-pr-builder/307/
Test PASSed (test).

@boegel
Copy link
Member

boegel commented Aug 7, 2015

Going in, thanks @Caylo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants