Support unittesting via 'python setup.py test' #193

stdweird · 2015-10-08T09:10:07Z

fixes #192

hpcugentbot · 2015-10-08T09:10:48Z

One or more tests FAILed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/336/console for more details.

hpcugentbot · 2015-10-08T09:25:25Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/337/console for more details.

stdweird · 2015-10-08T09:33:17Z

retest this please

hpcugentbot · 2015-10-08T09:35:30Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/338/console for more details.

stdweird · 2015-10-08T09:38:03Z

last tests ran with adapted jenkins to use setup.py test

wdpypere · 2015-10-08T09:51:54Z

setup.py



 PACKAGE = {
    'name': 'vsc-base',
-    'version': '2.3.0',


no more version?

@wdpypere: psst, there's a line below this one ;)

nice catch, restored and bumped

itkovian · 2015-10-08T09:53:47Z

lib/vsc/install/shared_setup.py

+wdp = ('Wouter Depypere', 'wouter.depypere@ugent.be')
+kw = ('Kenneth Waegeman', 'Kenneth.Waegeman@UGent.be')
+eh = ('Ewan Higgs', 'Ewan.Higgs@UGent.be')
+wp = ('Ward Poelmans', 'Ward.Poelmans@UGent.be')


Maybe keep them ordered alphabetically?

hpcugentbot · 2015-10-08T09:55:16Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/339/console for more details.

boegel · 2015-10-08T09:58:31Z

test/runner.py

@@ -2,6 +2,9 @@
 import os
 import sys

+if __name__ == '__main__':
+    sys.path.insert(0, os.path.dirname(os.path.dirname(__file__)))


this was kicked out in a previous PR, why add it again?

if it's really needed (it shouldn't), please add a clear comment here

it will break again if we remove the hack from setup.py

This hack is not (really) related to the one in setup.py, I think...

This one is for the import tests below, the one in setup.py is for import vsc.install (since the latter insert .../lib)

this is for people who run the tests with python test/runner.py, as is clear from the if ... above

Could you avoid this hack by using relative imports? import .docs ad tdo, etc?

how would relative imports pickup something differently then what sys.path sets as order?

don't relative imports imply only looking in the dir where the current module is located?

not really sure here, trying to find alternatives, the hack just feels wrong (but I guess it's not a blocker)

the whole runner.py can be removed 😄

ok, even better, but then we should bump to 2.4?

hpcugentbot · 2015-10-08T11:51:14Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/340/console for more details.

hpcugentbot · 2015-10-08T15:30:49Z

One or more tests FAILed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/341/console for more details.

hpcugentbot · 2015-10-08T15:40:25Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/342/console for more details.

stdweird · 2015-10-08T15:44:27Z

@boegel @JensTimmerman i added support to filter tests

boegel · 2015-10-08T22:09:17Z

lib/vsc/install/shared_setup.py

+try:
+    from unittest.suite import TestSuite
+except ImportError:
+    from unittest import TestSuite


the fallback is for older Python versions or something? add a comment to clarify please

yes, py2.6 ism

boegel · 2015-10-08T22:24:12Z

lib/vsc/install/shared_setup.py

+        self.test_filterf = None
+        self.test_loader = "vsc.install.shared_setup:VscScanningLoader"
+
+    def run_tests(self):


missing docstring

boegel · 2015-10-08T22:36:40Z

@stdweird: fully reviewed, mostly minor remarks and things that are not fully clear (to me)

I still feel there's a lot of stuff being done here, which makes it feel like we're missing something, it's too complicated. Although, the filter support does add quite a bit the code in here, of course.

hpcugentbot · 2015-10-09T07:57:10Z

One or more tests FAILed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/344/console for more details.

stdweird · 2015-10-09T07:59:26Z

retest this please

hpcugentbot · 2015-10-09T08:02:27Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/345/console for more details.

boegel · 2015-10-09T08:07:06Z

lib/vsc/install/shared_setup.py

+    from unittest.suite import TestSuite
+except ImportError:
+    # py2.6
+    from unittest import TestSuite


no need for the exception for py2.7?

-bash-4.1$ python -c "import sys; print sys.version; from unittest import TestSuite" 2.6.6 (r266:84292, Jul 22 2015, 16:47:47) [GCC 4.4.7 20120313 (Red Hat 4.4.7-16)] -bash-4.1$ module load Python/2.7.9-foss-2015a -bash-4.1$ python -c "import sys; print sys.version; from unittest import TestSuite" 2.7.9 (default, Sep 1 2015, 15:59:22) [GCC 4.9.2] -bash-4.1$

-bash-4.1$ python -c "import sys; print sys.version; from unittest.suite import TestSuite as T1; from unittest import TestSuite as T2; print T1 is T2" 2.7.9 (default, Sep 1 2015, 15:59:22) [GCC 4.9.2] True

ok, probably some init magic

hpcugentbot · 2015-10-09T08:13:31Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/346/console for more details.

hpcugentbot · 2015-10-09T08:19:47Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/347/console for more details.

boegel · 2015-10-09T08:44:35Z

lib/vsc/install/shared_setup.py

+from setuptools.command.install_scripts import install_scripts
+# egg_info uses sdist directly through manifest_maker
+from setuptools.command.sdist import sdist
+from setuptools.command.egg_info import egg_info


sort these?

hpcugentbot · 2015-10-09T08:56:15Z

All tests PASSed.

See https://jenkins1.ugent.be/job/vsc-base-pr-builder/348/console for more details.

boegel · 2015-10-09T09:03:53Z

Going in, let's see what's broken. ;-)

Support unittesting via 'python setup.py test'

boegel · 2015-10-09T09:22:33Z

test/runner.py

-
-try:
-    import xmlrunner
-    rs = xmlrunner.XMLTestRunner(output="test-reports").run(suite)


@stdweird: Jenkins relies on having this available

wdpypere reviewed Oct 8, 2015
View reviewed changes

stdweird added 2 commits October 8, 2015 11:52

Support unittesting via 'python setup.py test'

7213bfd

restore sys.path hack to be able to use vsc.install

480b2d0

stdweird force-pushed the setup_test branch from 7cd32b5 to 480b2d0 Compare October 8, 2015 09:53

itkovian reviewed Oct 8, 2015
View reviewed changes

boegel reviewed Oct 8, 2015
View reviewed changes

Address remarks

96bac0e

Add test filters: -F filters testmodules, -f filters test functions

64cdfee

stdweird force-pushed the setup_test branch from 530eb7d to 64cdfee Compare October 8, 2015 15:38

stdweird mentioned this pull request Oct 8, 2015

Generaloption: handle option-as-value #185

Merged

boegel reviewed Oct 8, 2015
View reviewed changes

stdweird added 2 commits October 9, 2015 09:55

bye bye runner, you won't be missed

dc2f184

bump to 2.4.0

571edb3

boegel reviewed Oct 9, 2015
View reviewed changes

stdweird force-pushed the setup_test branch from 50db6c0 to 3551d2c Compare October 9, 2015 08:10

Address remark and cleanup legacy distutils-only

18ed55a

stdweird force-pushed the setup_test branch from 3551d2c to 18ed55a Compare October 9, 2015 08:16

boegel reviewed Oct 9, 2015
View reviewed changes

Address next round of remarks

7714e17

boegel added a commit that referenced this pull request Oct 9, 2015

Merge pull request #193 from stdweird/setup_test

1322498

Support unittesting via 'python setup.py test'

boegel merged commit 1322498 into hpcugent:master Oct 9, 2015

boegel reviewed Oct 9, 2015
View reviewed changes

Support unittesting via 'python setup.py test' #193

Support unittesting via 'python setup.py test' #193

Conversation

stdweird commented Oct 8, 2015

hpcugentbot commented Oct 8, 2015

hpcugentbot commented Oct 8, 2015

stdweird commented Oct 8, 2015

hpcugentbot commented Oct 8, 2015

stdweird commented Oct 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hpcugentbot commented Oct 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hpcugentbot commented Oct 8, 2015

hpcugentbot commented Oct 8, 2015

hpcugentbot commented Oct 8, 2015

stdweird commented Oct 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boegel commented Oct 8, 2015

hpcugentbot commented Oct 9, 2015

stdweird commented Oct 9, 2015

hpcugentbot commented Oct 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hpcugentbot commented Oct 9, 2015

hpcugentbot commented Oct 9, 2015

Choose a reason for hiding this comment

hpcugentbot commented Oct 9, 2015

boegel commented Oct 9, 2015

Choose a reason for hiding this comment