print warning and resolve to absolute path for commands specified with relative path #320

boegel · 2021-10-12T10:12:52Z

No description provided.

…h relative path

lib/vsc/utils/py2vs3/py2.py

lib/vsc/utils/run.py

stdweird · 2021-10-12T10:24:40Z

lib/vsc/utils/run.py

@@ -87,6 +87,38 @@
 SHELL = BASH


+def ensure_cmd_abs_path(cmd):


allow to pass path to which

fixed in 919b9ec

stdweird · 2021-10-12T10:25:37Z

lib/vsc/utils/run.py

@@ -172,7 +204,7 @@ def __init__(self, cmd=None, **kwargs):
        if not hasattr(self, 'log'):
            self.log = getLogger(self._get_log_name())

-        self.cmd = cmd  # actual command
+        self.cmd = ensure_cmd_abs_path(cmd)  # actual command


allow path as kwargs (call it command_path to avoid any conflict with other)

fixed in 919b9ec

boegel · 2021-10-12T13:37:26Z

Tests fail on:

OSError: Command PYTHONPATH="..." not found in $PATH!

That's a special case I haven't taken into account yet, indeed: the command to run is not necessarily the first string value, there may be environment stuff in front of it... Oh boy.

@stdweird Any suggestions come to mind on how to handle this edge case?

itkovian · 2021-10-13T14:41:54Z

Split on and drop everything that matches a [a-z0-9A-Z_]+=[^ ]+ at the start of the list?

stdweird · 2021-10-14T04:18:36Z

@boegel solution is to only set absolute path when no shell is being used. in a shell, the shell will do this anyway

wdpypere · 2023-03-07T12:11:18Z

@boegel is this still needed? tbh, now we went py3 only I would suggest using pathlib is_absolute() but it seems this was never implemented?

boegel added 4 commits October 12, 2021 11:48

add which function to vsc.utils.py2vs3

1b9ab12

print warning and resolve to absolute path for commands specified wit…

d05d1ed

…h relative path

also check for warning produced by ensure_cmd_abs_path

32dbd34

bump version

4b34d05