Remove VLA #1273
Merged
Remove VLA #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
added
code quality ♻️
Explorer09
reviewed
Jul 28, 2023
| char cpuBrandString[cpuBrandStringSize]; | ||
| Platform_getCPUBrandString(cpuBrandString, cpuBrandStringSize); | ||
| char cpuBrandString[1024] = ""; | ||
| Platform_getCPUBrandString(cpuBrandString, sizeof(cpuBrandString)); |
There was a problem hiding this comment.
Technically not VLA but this change helps readability anyway :)
There was a problem hiding this comment.
Um, actually … ;-) Although this uses a constant number (which the compiler can deduce), syntactically it iswas.
BTW: I did a grep --color=always -nRP '\b(?!return)\w+ \w+\[[^\]0-9A-Z_]'|less -R through the source and had a look at the remaining locations found by this. Quite a nice way to quickly get through the source without straight up working with the AST …
fasterit
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes various instances of VLA in the code.
The two instances in
RichString.c(RichString_writeFromWide&RichString_appendnWideColumns) have been kept intentionally, for performance reasons AND the alternatives (likealloca) would be less clear.Those cases aside, I hope I caught all the other instances of VLA in the code.