Introduce autoTitleRightAlign column flag #1297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of handling PERCENT_CPU as a special case for whether to align the title of a dynamically sized column to the right or the left introduce a new flag, which can be reused by other columns.
natoscott
reviewed
Sep 3, 2023
| @@ -209,6 +209,9 @@ typedef struct ProcessFieldData_ { | |||
|
|
|||
| /* Whether the column width is dynamically adjusted (the minimum width is determined by the title length) */ | |||
| bool autoWidth; | |||
|
|
|||
| /* Whether the title of a column with dynamically adjusted width is right aligned (default is left aligned) */ | |||
| bool autoTitleRightAlign; | |||
There was a problem hiding this comment.
Is there anything automatic about the alignment? (i.e. could the name be simplified to just 'titleRightAlign'?)
There was a problem hiding this comment.
That auto refers to the automatic resize of certain columns.
|
My concerns about the
|
|
Applied via cbcfc5f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of handling PERCENT_CPU as a special case for whether to align the title of a dynamically sized column to the right or the left introduce a new flag, which can be reused by other columns.
Split from #1288
/cc @Explorer09