-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaken constraints #24
Conversation
@@ -88,4 +100,12 @@ object BlockingHttp4sServlet { | |||
DefaultServiceErrorHandler, | |||
dispatcher, | |||
) | |||
|
|||
protected[servlet] def apply[F[_]]( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one? I think your only recourse to preserve static forwarders is to leave it public and rely on deprecation and source-incompatible changes to dissuade use, as you've done here. Not sure what protected
does for object
methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think that was the trick I was thinking of... we make the implicit explicit. And we have to make it public for that static forwarder. Sad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in Scala 3 it's the other way around. Even package-private object methods will generate static-forwarders.
This causes problems with MiMa for internal methods, however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuck. I'm just going to leave that one alone then. They can use the constructor, and Servlet > 3 is coming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you have here is fine for Scala 2 and 3. The Scala 3 thing works in our favor here, but bites in different situations until MiMa can fix it.
f34824e
to
9512791
Compare
I think maybe the sbt-http4s-org upgrade on the merge commit is enforcing more things, but I don't know why it wasn't already broken? The last three commits are odd. |
Ah, it's because you were seeing build failures on the "push" jobs, not the "merge" jobs. I think this PR was based against a bad branch. |
Yeah, branches were in flux as I was doing this. |
No description provided.