Separate Layouts and Maps #515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garakmon
force-pushed
the
slam
branch
3 times, most recently
from
33c7293
to
91c7a2a
Compare
... because the color of the icon does not mean anything until map has been loaded into memory for example, if the map's layout has changed then it should be marked as modified but that wouldn't happen if the map is unloaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature-complete. In need of cleanup and testing.
Internally removes Layout related code from the Map class.
Creates a new layout-only edit mode.
Adds ability to modify map groups.
closes #182
closes #477
closes #181
closes #334
TODO:
in order of edits madeScriptUtility::setMainTab(int index)consider edit modegMapGroup_prefix requirement for map groupsNewMapPopup::initUiwhere neededRearrange and rename map sections?