Resolved MissingIndex error in similarity search #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I found that the "embeddings" missing index error happens because the FAISS index was being added before the embeddings were properly generated.
This update ensures that the embeddings are fully created first, and then the FAISS index is added for both text and image embeddings.
I've tested the fix locally, and it works without any issues now!
Fixes #205
Who can review?
@merveenoyan @stevhliu