New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation : structured generation into korean #207

Merged

stevhliu merged 5 commits into huggingface:main from 4N3MONE:ko-structured_generation

Oct 15, 2024

Contributor

4N3MONE commented Sep 24, 2024 •

edited

Loading

What does this PR do?

this is PR presents the korean translation of RAG with source highlighting using Structured generation cookbook.

Who can review?

@jeongiin, @harheem, @boyunJang, @ahnjj, @SeungAhSon,@jun048098,@win2dvp21

May you please review this PR? @merveenoyan @stevhliu.

4N3MONE added 3 commits

September 19, 2024 16:47


          nmt draft

c500433


          fix toctree

38d907f


          Update index.md

327d749

review-notebook-app bot commented Sep 24, 2024

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

4N3MONE marked this pull request as ready for review

September 24, 2024 01:43

jeongiin reviewed

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved


          Update notebooks/ko/structured_generation.ipynb

8f980b5

Co-authored-by: timdalxx <48753785+jeongiin@users.noreply.github.com>

harheem reviewed

View reviewed changes

notebooks/ko/structured_generation.ipynb Show resolved Hide resolved

notebooks/ko/structured_generation.ipynb Show resolved Hide resolved

notebooks/ko/structured_generation.ipynb Show resolved Hide resolved

4N3MONE commented

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved

4N3MONE commented

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved

4N3MONE commented

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved

4N3MONE commented

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved

4N3MONE commented

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved

4N3MONE commented

View reviewed changes

notebooks/ko/structured_generation.ipynb Outdated Show resolved Hide resolved


          Apply suggestions from code review

ad10f26

stevhliu approved these changes

View reviewed changes

Member

stevhliu left a comment

Thanks for your translation, great work! The doc-builder is having some issues at the moment, but we can merge once its fixed 🙂

Contributor Author

4N3MONE commented Oct 9, 2024 •

edited

Loading

Thanks for your translation, great work! The doc-builder is having some issues at the moment, but we can merge once its fixed 🙂

Thanks for the review, i'll ask for review&merge again in a week or so 😄

Member

stevhliu commented Oct 15, 2024

This should be ok to merge since it is fixed in huggingface/doc-builder#531.

stevhliu merged commit c8004a3 into huggingface:main

1 check failed

Contributor Author

4N3MONE commented Oct 15, 2024

thanks again @stevhliu ,but i find build_pr_documentation has failed. can you take a look?

Member

stevhliu commented Oct 21, 2024

The error before was related to the environment used in the CI, but it should be fixed now in huggingface/doc-builder#533!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet