-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation : structured generation into korean #207
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: timdalxx <48753785+jeongiin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your translation, great work! The doc-builder is having some issues at the moment, but we can merge once its fixed 🙂
Thanks for the review, i'll ask for review&merge again in a week or so 😄 |
This should be ok to merge since it is fixed in huggingface/doc-builder#531. |
thanks again @stevhliu ,but i find build_pr_documentation has failed. can you take a look? |
The error before was related to the environment used in the CI, but it should be fixed now in huggingface/doc-builder#533! |
What does this PR do?
this is PR presents the korean translation of RAG with source highlighting using Structured generation cookbook.
Who can review?
@jeongiin, @harheem, @boyunJang, @ahnjj, @SeungAhSon,@jun048098,@win2dvp21
May you please review this PR? @merveenoyan @stevhliu.