Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video support #3089

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add video support #3089

wants to merge 1 commit into from

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Oct 25, 2024

videos in /first-rows and /rows will be like

{"src": "https://huggingface.co/datasets/username/dataset_name/resolve/commit/hash/path/to/video.mp4"}

when possible, otherwise the back-ends store videos in the assets on S3 as usual (e.g. if they come from parquet or webdataset data or zipped data)

TODO: support hf:// urls in URLPreparator

@severo
Copy link
Collaborator

severo commented Oct 25, 2024

I remember you mentioned at one point that some video datasets have one video, and each row refers to a range [start, end], which would be accessed as "media fragments" in HTML: https://developer.mozilla.org/en-US/docs/Web/Media/Audio_and_video_delivery#specifying_playback_range. Is it still a thing, or do we just have one row = one video?

@lhoestq
Copy link
Member Author

lhoestq commented Oct 27, 2024

one row = one video (we'll see later if we need to support other cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants