Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config saving when check on misplaced args broken #966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Oct 24, 2024

What does this PR do?

some model configs does not expect be loaded without arguments that required for checking misplaced arguments in 4.45 release (example https://huggingface.co/OpenGVLab/InternVL2-1B). This fix allows ignoring such cases for loading and saving config files

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova force-pushed the ea/fix_config_save branch 2 times, most recently from 978b6f7 to f10cf64 Compare October 24, 2024 10:49
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova force-pushed the ea/fix_config_save branch 2 times, most recently from e4e28dc to 9978afd Compare October 24, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants