Add missing options in pipeline API #884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyagp
commented
Aug 8, 2024
src/pipelines.js
Outdated
| @@ -1,15 +1,15 @@ | |||
| /** | |||
| * @file Pipelines provide a high-level, easy to use, API for running machine learning models. | |||
| * | |||
| * | |||
There was a problem hiding this comment.
My editor trims the tailing spaces. Please let me know if you don't like this change. For review, you may set the option to "Hide whitespace".
|
@xenova Please review this change, thanks! |
|
Thanks! To keep the diff small (and consistent across other files), can you add back the whitespace for those lines (I am adding prettier which should fix this later)? |
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add missing options in pipeline API to align with from_pretrained API.
Bug #883 can be fixed with this. That model has a separate data file, so use_external_data_format has to be supported and designated to true.