Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Apollo client #1112

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Configure Apollo client #1112

merged 1 commit into from
Oct 31, 2020

Conversation

NuckChorris
Copy link
Member

Extracted from #1107, this is the configuration of the Apollo client so we can merge this (to be used in mod tools) while we finish off Nolt stuff

@NuckChorris NuckChorris added type:enhancement javascript Pull requests that update Javascript code labels Oct 31, 2020
@NuckChorris NuckChorris requested a review from a team October 31, 2020 03:15
Co-Authored-By: Matthew Dias <matthewdias@me.com>
Co-Authored-By: James Harris <wopian@wopian.me>
@@ -138,5 +140,8 @@
},
"resolutions": {
"ember-power-select/ember-concurrency": "0.8.27"
},
"dependencies": {
"@apollo/client": "^3.1.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure this is right tbh, I thought ember was all devDependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yeah that might have been my bad. i think you can safely move it back to dev.

@NuckChorris NuckChorris merged commit 0669a74 into the-future Oct 31, 2020
@NuckChorris NuckChorris deleted the feature/apollo branch October 31, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants