Conversation
This comment was marked as outdated.
This comment was marked as outdated.
this commit introduces a new body middleware, `Chain<A, B>`. similar to [`std::iter::Iterator::chain()`], this provides an adapter to join two bodies together. a new [`BodyExt::chain()`] trait method is introduced as a facility to create a chained body using `a.chain(b)` syntax. that method will return a new [`Body`][http_body::Body] that emits the contents of the first body, and then emits the contents of the second body. If the first body returns an error, the body will consider itself finished and will not poll the second body. a test suite is included to confirm that this properly handles state transitions for empty bodies, errors, and trailers. the test suite also includes assertions to show that hints (`is_end_stream()` and `size_hint()`) work properly. Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
marked this pull request as ready for review
August 28, 2026 15:54
seanmonstar
reviewed
Aug 31, 2026
seanmonstar
left a comment
seanmonstar
left a comment
Member
There was a problem hiding this comment.
Very cool! My first thought at seeing the title was 'what about chained trailers', and you addressed that, thanks! I just left one thought inline regarding potential clarity.
#178 (comment) Signed-off-by: katelyn martin <git@katelyn.world>
Signed-off-by: katelyn martin <git@katelyn.world>
seanmonstar
approved these changes
Aug 31, 2026
cratelyn
added a commit
that referenced
this pull request
Sep 2, 2026
this commit introduces a `Pending<D, E>` body that is akin to `futures_util`'s `pending()` future. this is a body that will always yield `Poll::Pending` when it is polled. in tandem with `Chain<A, B>` (see #178), this can be used to write test coverage for hanging request or response bodies, and to exercise timeout logic. Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
added a commit
that referenced
this pull request
Sep 2, 2026
this commit introduces a `Pending<D, E>` body that is akin to `futures_util`'s `pending()` future. this is a body that will always yield `Poll::Pending` when it is polled. in tandem with `Chain<A, B>` (see #178), this can be used to write test coverage for hanging request or response bodies, and to exercise timeout logic. Signed-off-by: katelyn martin <git@katelyn.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit introduces a new body middleware,
Chain<A, B>.similar to
std::iter::Iterator::chain(), this provides an adapter to join two bodies together. a newBodyExt::chain()trait method is introduced as a facility to create a chained body usinga.chain(b)syntax.that method will return a new
http_body::Bodythat emits the contents of the first body, and then emits the contents of the second body. if the first body returns an error, the body will consider itself finished and will not poll the second body.a test suite is included to confirm that this properly handles state transitions for empty bodies, errors, and trailers. the test suite also includes assertions to show that hints (
is_end_stream()andsize_hint()) work properly.