Skip to content

refactor(http1): resolve collapsible_match lint #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dswij merged 1 commit into from
Aug 31, 2026
Merged

refactor(http1): resolve collapsible_match lint #4178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ as_conversions = "allow" # TODO: tricky
cast_possible_truncation = "allow" # TODO: consider
cast_precision_loss = "allow" # TODO: consider
checked_conversions = "allow"
collapsible_match = "allow"
else_if_without_else = "allow"
enum_glob_use = "allow"
float_arithmetic = "allow"
Expand Down
8 changes: 3 additions & 5 deletions src/proto/h1/conn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,11 +676,9 @@ where
Version::HTTP_10 => self.state.disable_keep_alive(),
// If response is version 1.1 and keep-alive is wanted, add
// Connection: keep-alive header when not present
Version::HTTP_11 => {
if self.state.wants_keep_alive() {
head.headers
.insert(CONNECTION, HeaderValue::from_static("keep-alive"));
}
Version::HTTP_11 if self.state.wants_keep_alive() => {
head.headers
.insert(CONNECTION, HeaderValue::from_static("keep-alive"));
}
_ => (),
}
Expand Down
Loading