Fix address util nullish fallback handling (#3181)

### Description Small fix for address utils ### Related issues hyperlane-xyz/issues#899 ### Backward compatibility Yes ### Testing In warp UI
hyperlane-xyz · Jan 24, 2024 · df24eec · df24eec
1 parent 6845f9f
commit df24eec
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/polite-lobsters-boil.md b/.changeset/polite-lobsters-boil.md
@@ -0,0 +1,5 @@
+---
+'@hyperlane-xyz/utils': patch
+---
+
+Fix for address utils falsy fallbacks
diff --git a/typescript/utils/src/addresses.ts b/typescript/utils/src/addresses.ts
@@ -2,6 +2,7 @@ import { fromBech32, normalizeBech32, toBech32 } from '@cosmjs/encoding';
 import { PublicKey } from '@solana/web3.js';
 import { utils as ethersUtils } from 'ethers';
 
+import { isNullish } from './typeof';
 import { Address, HexString, ProtocolType } from './types';
 
 const EVM_ADDRESS_REGEX = /^0x[a-fA-F0-9]{40}$/;
@@ -67,7 +68,7 @@ function routeAddressUtil<T>(
 ) {
   protocol ||= getAddressProtocolType(param);
   if (protocol && fns[protocol]) return fns[protocol]!(param);
-  else if (fallback) return fallback;
+  else if (!isNullish(fallback)) return fallback;
   else throw new Error(`Unsupported protocol ${protocol}`);
 }
 

diff --git a/typescript/utils/src/typeof.ts b/typescript/utils/src/typeof.ts
@@ -1,6 +1,7 @@
-export function isNullish<T>(val: T) {
-  if (val === null || val === undefined) return true;
-  else return false;
+export function isNullish<T>(
+  val: T,
+): val is T extends null | undefined ? T : never {
+  return val === null || val === undefined;
 }
 
 export function isNumeric(value: string | number) {