Skip to content

Commit

Permalink
Make mailbox client upgrade safe (#2984)
Browse files Browse the repository at this point in the history
### Description

Pulls in changes from
#2904

### Related issues

- Fixes hyperlane-xyz/issues#593

### Backward compatibility

No, existing v3 MailboxClients (Routers) will be storage incompatible

### Testing

Unit Tests

---------

Co-authored-by: Michalis Kargakis <kargakis@protonmail.com>
  • Loading branch information
yorhodes and 0xmichalis authored Nov 28, 2023
1 parent df69370 commit df34198
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/hip-jobs-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperlane-xyz/core': minor
---

Includes storage gap in Mailbox Client for forwards compatibility
2 changes: 2 additions & 0 deletions solidity/contracts/client/MailboxClient.sol
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ abstract contract MailboxClient is OwnableUpgradeable {

IInterchainSecurityModule public interchainSecurityModule;

uint256[48] private __GAP; // gap for upgrade safety

// ============ Modifiers ============
modifier onlyContract(address _contract) {
require(
Expand Down

0 comments on commit df34198

Please sign in to comment.