Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new CLI package #2573

Merged
merged 96 commits into from
Oct 14, 2023
Merged

Create new CLI package #2573

merged 96 commits into from
Oct 14, 2023

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jul 26, 2023

Description

  • Create new CLI package
  • Upgrade prettier, typescript, and lint packages
  • Update TSConfig output target to ES2020
  • Migrate code from hyp-deploy repo to typescript/cli/src
Screenshot 2023-07-29 at 3 28 01 PM

Related issues

Fixes #2566
Fixes #2786

Backward compatibility

Yes

Testing

Tested all commands locally.
Tested core deployments with and without pre-existing addresses (artifacts)
Created e2e tests for deploying core, warp, and sending messages.

Dogfooding

  1. 1 of 5
    aroralanuk avious00
    nambrot yorhodes

Rollout

  1. CLI dx
    jmrossy nambrot
    tkporter yorhodes

Upgrade prettier, typescript, and lint packages
Update TSConfig output target to ES2020
Copy code from hyp-deploy/src to cli/src
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9b1824a) 65.35% compared to head (80086bf) 65.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2573   +/-   ##
=======================================
  Coverage   65.35%   65.35%           
=======================================
  Files          95       95           
  Lines        1446     1446           
  Branches      189      189           
=======================================
  Hits          945      945           
  Misses        494      494           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmrossy jmrossy marked this pull request as ready for review July 29, 2023 22:03
Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will definitely need another pass but glad we are pulling this in

typescript/cli/ci-test.sh Show resolved Hide resolved
typescript/cli/cli.ts Outdated Show resolved Hide resolved
typescript/cli/examples/chain-config.yaml Outdated Show resolved Hide resolved
typescript/cli/examples/multisig-ism.yaml Outdated Show resolved Hide resolved
typescript/cli/src/send/transfer.ts Outdated Show resolved Hide resolved
typescript/cli/src/utils/files.ts Show resolved Hide resolved
typescript/helloworld/package.json Show resolved Hide resolved
typescript/sdk/src/consts/agentStartBlocks.ts Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
typescript/cli/cli.ts Outdated Show resolved Hide resolved
typescript/cli/examples/multisig-ism.yaml Show resolved Hide resolved
typescript/cli/ci-test.sh Show resolved Hide resolved
typescript/cli/ci-test.sh Show resolved Hide resolved
typescript/cli/src/config/multisig.ts Show resolved Hide resolved
typescript/cli/src/config/warp.ts Show resolved Hide resolved
typescript/cli/src/send/transfer.ts Show resolved Hide resolved
typescript/sdk/src/app/HyperlaneApp.ts Show resolved Hide resolved
@jmrossy jmrossy enabled auto-merge (squash) October 14, 2023 21:10
@jmrossy jmrossy merged commit fd48f13 into main Oct 14, 2023
25 checks passed
@jmrossy jmrossy deleted the rossy/cli branch October 14, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

E2E tests for CLI ETH global hackathon warp/deploy feedback
5 participants