Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent Config Parsing Casing Fixes #2666

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Conversation

mattiekat
Copy link
Contributor

Description

This is a fix for an issue in the arguments and environment where we are unable to correctly support attribute names due to the casing. The main issue cannot be fully fixed practically by this PR because it would cause some configuration cases to break. For now it adds manual exceptions for the command line argument case and leaves envs as they were. There are then two new parsers that can be used with the new config format.

Drive-by changes

Also adds this to argument parser since it was trivial to copy/paste it and it will allow us to harden parsing when we switch over.

Related issues

Backward compatibility

Yes

Testing

Unit Tests

@mattiekat mattiekat marked this pull request as ready for review August 16, 2023 23:40
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0d3dd60) 64.61% compared to head (fc4b509) 64.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   64.61%   64.61%           
=======================================
  Files          90       90           
  Lines        1379     1379           
  Branches      182      182           
=======================================
  Hits          891      891           
  Misses        481      481           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattiekat mattiekat enabled auto-merge (squash) August 18, 2023 18:05
@mattiekat mattiekat merged commit 7c989e7 into main Aug 18, 2023
13 of 24 checks passed
@mattiekat mattiekat deleted the mattie/config/fix-args-and-env branch August 18, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants