-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create EvmCoreModule with create() #3737
Conversation
🦋 Changeset detectedLatest commit: 11fb842 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your new classes mostly look good to me! Raised some concerns about the config handling that I see emerging but it doesn't have to be solved here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad we could mostly reuse existing deployer code :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cli-2.0 #3737 +/- ##
========================================
Coverage 63.96% 63.96%
========================================
Files 124 124
Lines 1543 1543
Branches 167 167
========================================
Hits 987 987
Misses 530 530
Partials 26 26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits but lgtm, will let yorhodes ✅
don't forget to add a changeset! |
Co-authored-by: Paul Balaji <paul@hyperlane.xyz>
Co-authored-by: Paul Balaji <paul@hyperlane.xyz>
Co-authored-by: Paul Balaji <paul@hyperlane.xyz>
Co-authored-by: Paul Balaji <paul@hyperlane.xyz>
Co-authored-by: Paul Balaji <paul@hyperlane.xyz>
Co-authored-by: Paul Balaji <paul@hyperlane.xyz>
…yperlane-monorepo into ltyu/core-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I expect there to be a little more complexity in the update
Description
This Pull Request introduces the new EVM core module be implementing the
create()
function. Currently,create()
will call the existing CoreDeployerRelated issues
CoreCrudModule
create()
#3575Backward compatibility
Yes
Testing
Unit Tests