Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore warnings from fx-portal lib #3761

Merged
merged 1 commit into from
May 10, 2024
Merged

fix: ignore warnings from fx-portal lib #3761

merged 1 commit into from
May 10, 2024

Conversation

paulbalaji
Copy link
Contributor

does what the title says, making use of https://www.npmjs.com/package/hardhat-ignore-warnings
image

Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 3a908f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cmcewen cmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need a few more reps in the repo before approving PRs but overall would say LGTM!

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (ed7d63d) to head (3a908f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3761   +/-   ##
=======================================
  Coverage   67.91%   67.91%           
=======================================
  Files         124      124           
  Lines        1527     1527           
  Branches      167      167           
=======================================
  Hits         1037     1037           
  Misses        462      462           
  Partials       28       28           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 67.50% <ø> (ø)
isms 71.85% <ø> (ø)
token 65.41% <ø> (ø)
middlewares 77.05% <ø> (ø)

Copy link
Contributor

@nbayindirli nbayindirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

solidity/hardhat.config.cts Show resolved Hide resolved
@paulbalaji paulbalaji enabled auto-merge (squash) May 10, 2024 15:33
@paulbalaji paulbalaji merged commit 78d3e62 into main May 10, 2024
39 of 40 checks passed
@paulbalaji paulbalaji deleted the pb/chore-hh-warn branch May 10, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants