feat: multi collateral warp routes #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24201d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yorhodes
changed the title
yorhodes
requested review from
tkporter,
nambrot,
jmrossy,
aroralanuk and
nbayindirli
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3820 +/- ##
=======================================
Coverage 63.96% 63.96%
=======================================
Files 124 124
Lines 1543 1543
Branches 167 167
=======================================
Hits 987 987
Misses 530 530
Partials 26 26
|
yorhodes
requested review from
ltyu
and removed request for
tkporter,
aroralanuk,
Skunkchain and
avious00
2 tasks
jmrossy
reviewed
May 22, 2024
ltyu
reviewed
May 22, 2024
ltyu
reviewed
May 22, 2024
ltyu
reviewed
May 22, 2024
ltyu
reviewed
May 22, 2024
ltyu
reviewed
May 22, 2024
jmrossy
approved these changes
May 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
### Description Token deployer should always derive token metadata's total supply to 0, otherwise the collateral token's total supply will be minted initially on the synthetic, creating 2x the desired total supply. ### Related issues - Regression introduced by #3820 - opens #4013 ### Backward compatibility Yes ### Testing Unit Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds multicollateral warp route support to the CLI. Dedupes SDK warp route types and zod schemas (via type inference).
Drive-by changes
Related issues
Backward compatibility
Testing