-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evm): collaborative indexing through txid sharing #3833
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
=======================================
Coverage 62.76% 62.76%
=======================================
Files 125 125
Lines 1579 1579
Branches 175 175
=======================================
Hits 991 991
Misses 561 561
Partials 27 27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but I believe #3833 (comment) may need to be changed before merging
Description
Drive-by changes
contract_sync/cursors/mod.rs
Debug
to exclude fields that aren't relevant to debugging (maybe there's even a macro annotation to exclude, but I haven't checked)MpmcReceiver
->BroadcastReceiver
Related issues
Backward compatibility
Testing
e2e tested with the watermark cursor manually disabled