feat: WarpModule with create() #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Add Reader to derive WarpConfig from TokenRouter address ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes #3579 ### Backward compatibility Yes ### Testing Unit Tests
Signed-off-by: Paul Balaji <paul@hyperlane.xyz>
### Description Add Reader to derive WarpConfig from TokenRouter address ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes #3579 ### Backward compatibility Yes ### Testing Unit Tests
Add Reader to derive WarpConfig from TokenRouter address <!-- Are there any minor or drive-by changes also included? --> - Fixes #3579 Yes Unit Tests
### Description Fixes owner config to be safes ### Backward compatibility Yes
- Remove most consts from SDK - Refactor tests that relied on chainMetadata - Remove JSON imports/exports in the SDK - Update the HelloWorld package to read metadata from the registry lib - Update the Infra package to read/write to a LocalRegistry - Update the CLI to read and write from registries - Fix typo in `EvmHypCollateralVault` token standard - Use consistent, newest yaml lib version Fixes hyperlane-xyz/issues#917 Fixes #2810 No: - Several SDK exports like `chainMetadata` have been removed - Common args for the CLI like `--chain` have been replaced with `--registry` and `--overrides`
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
04349e2
to
a910681
Compare
yorhodes
requested changes
May 27, 2024
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
2 times, most recently
from
fa2ad20
to
65e4ed5
Compare
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
65e4ed5
to
9bd4308
Compare
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
1aa8cfc
to
0470ad0
Compare
…terConfig where applicable
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
0470ad0
to
7b40cca
Compare
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
0c54b9c
to
b43bdd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cli-2.0 #3838 +/- ##
==========================================
Coverage ? 62.76%
==========================================
Files ? 125
Lines ? 1579
Branches ? 175
==========================================
Hits ? 991
Misses ? 561
Partials ? 27
|
nbayindirli
reviewed
Jun 5, 2024
yorhodes
approved these changes
Jun 5, 2024
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
72b7ae4
to
a971db9
Compare
ltyu
force-pushed
the
warpCrudModule_createOnly
branch
from
a971db9
to
d28ab7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive by
Address) #3773Related issues
WarpCrudModulecreate()#3839Backward compatibility
Yes
Testing
Unit Tests