Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agent log verbosity #4054

Merged
merged 5 commits into from
Jun 27, 2024
Merged

fix: agent log verbosity #4054

merged 5 commits into from
Jun 27, 2024

Conversation

daniel-savu
Copy link
Contributor

Description

tbh I don't know why, but this makes all the logs we were previously missing show up in e2e:

Drive-by changes

Related issues

Backward compatibility

Testing

E2E, by counting occurrences of the two logs linked above in relayer log output. Before this change, those logs would be missing completely

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 1a625c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.56%. Comparing base (892efd4) to head (1a625c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4054   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         129      129           
  Lines        1656     1656           
  Branches      176      176           
=======================================
  Hits         1003     1003           
  Misses        626      626           
  Partials       27       27           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 67.50% <ø> (ø)
isms 39.52% <ø> (ø)
token 62.83% <ø> (ø)
middlewares 77.05% <ø> (ø)

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@daniel-savu daniel-savu enabled auto-merge (squash) June 27, 2024 11:24
@daniel-savu daniel-savu enabled auto-merge (squash) June 27, 2024 13:17
@paulbalaji
Copy link
Contributor

will require pulling main after #3981 gets merged

@paulbalaji paulbalaji disabled auto-merge June 27, 2024 14:33
@paulbalaji paulbalaji added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit befc38d Jun 27, 2024
38 checks passed
@paulbalaji paulbalaji deleted the dan/fix-agent-verbosity branch June 27, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent debug logs should always be present when configured
3 participants