Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect use of blacklist variable #4099

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

lyfsn
Copy link
Contributor

@lyfsn lyfsn commented Jul 5, 2024

Description

Otherwise, the whitelist will not work; any whitelist parameter will function as a blocklist.

Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: 93f984a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lyfsn lyfsn changed the title Fix incorrect use of blacklist variable fix: incorrect use of blacklist variable Jul 5, 2024
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, very surprised (and ashamed) to see this! Great find. Thank you for the fix!

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.37%. Comparing base (95f6421) to head (93f984a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4099   +/-   ##
=======================================
  Coverage   81.37%   81.37%           
=======================================
  Files         100      100           
  Lines        1412     1412           
  Branches      178      178           
=======================================
  Hits         1149     1149           
  Misses        263      263           
Components Coverage Δ
core 96.92% <ø> (ø)
hooks 82.38% <ø> (ø)
isms 92.47% <ø> (ø)
token 93.05% <ø> (ø)
middlewares 86.52% <ø> (ø)

@tkporter tkporter added this pull request to the merge queue Sep 12, 2024
Merged via the queue into hyperlane-xyz:main with commit b326d4b Sep 12, 2024
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants