-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alert instead of crashing relayer when building cursors #4811
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4811 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 101 101
Lines 1481 1481
Branches 192 192
=======================================
Hits 1100 1100
Misses 360 360
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine we'll wanna document this in the public docs at some point
@tkporter good point, I'll add a quick entry to the relayer monitoring & alerting guide (https://docs.hyperlane.xyz/docs/operate/relayer/monitoring-alerting) |
Description
unwrap
s outside atokio::spawn
, otherwise they'll take down the entire relayer. The offenders have so far been the indexing cursors, so this PR just logs an error and sets a new metric flag instead of panicking:critical_error
, anIntGauge
type because prometheus doesn't have boolean gauges. For now this is only used for origin chains, but I envision this as being set when a critical error occurs in the submitter too, in the futureDrive-by changes
Removes usage of
Builder
derive macro in metric types, since they're not complex enough to warrant itRelated issues
Backward compatibility
Yes
Testing
the existing e2e