Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): PR parity to include hyphen in title #3557

Open
jagpreetsinghsasan opened this issue Sep 30, 2024 · 0 comments · May be fixed by #3594
Open

ci(github): PR parity to include hyphen in title #3557

jagpreetsinghsasan opened this issue Sep 30, 2024 · 0 comments · May be fixed by #3594
Assignees
@jagpreetsinghsasan
Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented Sep 30, 2024 •
edited
Loading

Describe the bug

Commit Parity currently fails due to hyphen present in the commit message

To Reproduce

https://github.com/hyperledger/cacti/pull/3555
or
#3576

Expected behavior

The commit - PR parity should pass
@jagpreetsinghsasan jagpreetsinghsasan added bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Sep 30, 2024
@jagpreetsinghsasan jagpreetsinghsasan self-assigned this Sep 30, 2024
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Oct 8, 2024
Open
5 tasks
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Oct 17, 2024
ci(github): pr parity to include hyphen
bfb0db9 
    Primary Changes
    ----------------
    1. Updated the code to remove the hyphen
       regex from the pr-commit parity script
    2. Removed an unused var from the workflow

Fixes hyperledger-cacti#3557

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan linked a pull request Oct 17, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(github): pr parity to include hyphen jagpreetsinghsasan/cactus
1 participant
@jagpreetsinghsasan