-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint #3576
base: main
Are you sure you want to change the base?
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint #3576
Conversation
223b741
to
1b42cb7
Compare
PR-Commit Parity is failing to a known bug: #3557 (This workflow result can be skipped for evaluating PR for merge) |
1b42cb7
to
e746fe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've left only two small nitpicks comments, please have a look, thanks.
.../src/test/typescript/integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts
Outdated
Show resolved
Hide resolved
.../src/test/typescript/integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts
Outdated
Show resolved
Hide resolved
e746fe1
to
befd829
Compare
@outSH re-requested for review, already done with your requested changes. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
befd829
to
381798d
Compare
…-endpoint Primary Changes ---------------- packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/ integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts Fixes hyperledger-cacti#3565 Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
381798d
to
f7cae77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, the besu test package's tests are failing, please fix those test failures (I think they were passing before this PR)
Commit to be reviewed
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint
Fixes #3565
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.