Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-besu): jest migrate get-past-logs-endpoint.test.ts #3529

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

petermetz
Copy link
Contributor

Depends on #3528 => test(test-tooling): add new besu AIO image builder utility

Fixes #3527

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz changed the title Petermetz/issue3527 test(connector-besu): jest migrate get-past-logs-endpoint.test.ts Sep 8, 2024
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@petermetz the parity check is failing as I am removing the Fixes/Depends lines before comparing the string as the string resolution of issue numbers #abcd in PR description is often done as hyperledger#abcd thus making the comparision harder.
Shall I push a fix (along with other gh issues around pr commit parity) to include these lines to be checked as well ?

@petermetz
Copy link
Contributor Author

LGTM @petermetz the parity check is failing as I am removing the Fixes/Depends lines before comparing the string as the string resolution of issue numbers #abcd in PR description is often done as hyperledger#abcd thus making the comparision harder. Shall I push a fix (along with other gh issues around pr commit parity) to include these lines to be checked as well ?

@jagpreetsinghsasan Got it, thanks! Yes, I would fix it by making sure to remove the fixes/depends lines from either both or none of them (commit message + pr description).

Copy link

dpulls bot commented Sep 10, 2024

🎉 All dependencies have been resolved !

Depends on hyperledger-cacti#3528 => test(test-tooling): add new besu AIO image builder utility

Fixes hyperledger-cacti#3527

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Copy link

This PR/issue depends on:

@petermetz petermetz merged commit 68d50ba into hyperledger-cacti:main Sep 10, 2024
147 of 149 checks passed
@petermetz petermetz deleted the petermetz/issue3527 branch September 10, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(connector-besu): jest migrate get-past-logs-endpoint.test.ts
3 participants