perf(github): add knob/flag to manually override CI skip #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zondervancalvez
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
zondervancalvez
force-pushed
the
zondervancalvez/issue2679
branch
from
680813d
to
d050fb6
Compare
jagpreetsinghsasan
requested changes
Oct 7, 2024
There was a problem hiding this comment.
@zondervancalvez please fix the pr-commit-parity check, address/reply/resolve the following review comments and re-request for review once done.
zondervancalvez
force-pushed
the
zondervancalvez/issue2679
branch
2 times, most recently
from
faf119b
to
edea1e5
Compare
jagpreetsinghsasan
requested changes
Oct 17, 2024
zondervancalvez
force-pushed
the
zondervancalvez/issue2679
branch
from
edea1e5
to
a547a30
Compare
Primary Changes ---------------- 1. Created a function to check if the commit message contains 'cacti-skip-ci' to skip the CI check. 2. Check if the request is from the maintainer or not. If he is a Maintainer, the CI-skip request will be granted, else not. Fixes hyperledger-cacti#2679 Signed-off-by: bado <zondervan.v.calvez@accenture.com>
zondervancalvez
force-pushed
the
zondervancalvez/issue2679
branch
from
a547a30
to
487e517
Compare
jagpreetsinghsasan
approved these changes
Oct 17, 2024
petermetz
reviewed
Oct 18, 2024
Comment on lines
2652
to
2654
| - dev No newline at end of file | ||
| - dev | ||
|
|
There was a problem hiding this comment.
@zondervancalvez Please clean up white space changes from the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
perf(github): add knob/flag to manually override CI skip
Fixes #2679
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.