-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ledger-browser): add links to documentation #3575
Conversation
@sirisayshello thankyou for your contribution to Hyperledger Cacti.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the above requested changes
@jagpreetsinghsasan certainly, I will make the requested changes! |
@jagpreetsinghsasan I have now updated the commit to include the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please do the same for fabric-browser app configuration as described in an issue :)
Changes ---------------- 1. Added links to documentation and setup guides for eth-browser and fabric-browser. Fixes hyperledger-cacti#3550 Signed-off-by: sirisayshello <veckovis.salongen0p@icloud.com>
@outSH Sorry, my bad; I missed that one. I have now made the requested changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
I verified that the commit message has been updated according to the requirements.
LGTM (Not approving this intentionally as Peter has already checked and approved, thus dismissing my review) |
Closing and re-opening in hopes of triggering the dpull bot |
Fixes #3550
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.