Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ledger-browser): add links to documentation #3575

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sirisayshello
Copy link
Contributor

@sirisayshello sirisayshello commented Oct 7, 2024

Changes
----------------
1. Added links to documentation and setup guides for eth-browser and fabric-browser.

Fixes #3550

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@jagpreetsinghsasan
Copy link
Contributor

@sirisayshello thankyou for your contribution to Hyperledger Cacti.
I have some review comments on this one

  1. Can you please comment on the task docs(ledger-browser): add links to documentation #3550 with something like I want to work on this, so that we can assign you the task. This helps us in avoiding duplications of the efforts spent on its completion.
  2. Can you update the commit message with what you wrote as the pr description as well? (All you have to do is amend the commit message with the exact copy paste of your pr description, without the Pull Request Requirements.... paragraph). This helps us with descriptive commit messages and a parity with the PR associated with them.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the above requested changes

@sirisayshello
Copy link
Contributor Author

@jagpreetsinghsasan certainly, I will make the requested changes!

@sirisayshello
Copy link
Contributor Author

sirisayshello commented Oct 8, 2024

@jagpreetsinghsasan I have now updated the commit to include the PR description.

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please do the same for fabric-browser app configuration as described in an issue :)

Changes
----------------
1. Added links to documentation and setup guides for eth-browser and fabric-browser.
Fixes hyperledger-cacti#3550

Signed-off-by: sirisayshello <veckovis.salongen0p@icloud.com>
@sirisayshello
Copy link
Contributor Author

@outSH Sorry, my bad; I missed that one. I have now made the requested changes!

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@petermetz petermetz dismissed jagpreetsinghsasan’s stale review October 10, 2024 05:08

I verified that the commit message has been updated according to the requirements.

@petermetz petermetz enabled auto-merge (rebase) October 10, 2024 05:08
@jagpreetsinghsasan
Copy link
Contributor

LGTM (Not approving this intentionally as Peter has already checked and approved, thus dismissing my review)

@petermetz petermetz changed the title docs(ledger-browser): add links to documentation docs(ledger-browser): add links to documentation Oct 10, 2024
@petermetz
Copy link
Contributor

Closing and re-opening in hopes of triggering the dpull bot

@petermetz petermetz closed this Oct 11, 2024
@petermetz petermetz reopened this Oct 11, 2024
@petermetz petermetz merged commit 8579017 into hyperledger-cacti:main Oct 14, 2024
287 of 291 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(ledger-browser): add links to documentation
4 participants