Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): potential CODEOWNERS syntax fix - one line per maintainer #3581

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Oct 9, 2024

We've been having sytnax issues with the CODEOWNERS file for years where
GitHub is claiming that the usernames of certain maintainers don't exist
even though they defintely do.

This is an attempt to get that error unstuck by adding each wildcard
entry as its own line in the text file. Will be interesting to see if this
makes to false-positive syntax errors go away.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it is still showing errors @petermetz
image

@outSH
Copy link
Contributor

outSH commented Oct 10, 2024

I think the failing maintainers are not part of this org (https://github.com/orgs/hyperledger-cacti/people?query=) and not in maintainers team (https://github.com/orgs/hyperledger-cacti/teams/cacti-maintainers), that may be the main issue

@ryjones
Copy link
Contributor

ryjones commented Oct 10, 2024

I think the failing maintainers are not part of this org (https://github.com/orgs/hyperledger-cacti/people?query=) and not in maintainers team (https://github.com/orgs/hyperledger-cacti/teams/cacti-maintainers), that may be the main issue

correct

@petermetz petermetz changed the title ci(github): potential CODEOWNERS syntax fix - one line per maintainer ci(github): potential CODEOWNERS syntax fix - one line per maintainer Oct 10, 2024
We've been having sytnax issues with the CODEOWNERS file for years where
GitHub is claiming that the usernames of certain maintainers don't exist
even though they defintely do.

This is an attempt to get that error unstuck by adding each wildcard
entry as its own line in the text file. Will be interesting to see if this
makes to false-positive syntax errors go away.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the ci-codeowners-one-maintainer-per-line-potential-fix branch from 1f59338 to 87b2178 Compare October 10, 2024 17:17
@petermetz
Copy link
Contributor Author

@ryjones @outSH @jagpreetsinghsasan Oh, OK, then this can be closed, thank you! :-)

@petermetz petermetz closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants