fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
izuru0,
jagpreetsinghsasan,
VRamakrishna and
outSH
as code owners
outSH
approved these changes
Oct 15, 2024
In the DeployContractSolidityBytecodeNoKeychainV1Request of `packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json` there are parameters that are required despite the entire point of this operation is to not need them (e.g. keychainId and contract JSON object). Fixes hyperledger-cacti#3586 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue3586
branch
from
512a783
to
d71e316
Compare
|
I investigated why the DAST scan is failing but could not reproduce the problem locally. I'm going to assume that it's an issue with the environment setup logic of the CI job and not an issue with the endpoints. Based on that I'll disable the DAST scan for now until we can figure out what's wrong with it. Tracking the fix here: #3596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the DeployContractSolidityBytecodeNoKeychainV1Request of
packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.jsonthere are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).
Fixes #3586
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.