Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOPS-3309: Add sonar & defectdojo analysis #440

Draft
wants to merge 45 commits into
base: iroha2-dev
Choose a base branch
from

ci: try sonar-scanner

0ec39ca
Select commit
Loading
Failed to load commit list.
Draft

DOPS-3309: Add sonar & defectdojo analysis #440

ci: try sonar-scanner
0ec39ca
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Nov 8, 2024 in 2s

Check failed

There are 10 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 ca0a50a Add sonar & defectdojo analysis Valid sign-off found
🟢 15f126a use self-hosted Valid sign-off found
🟢 d50be93 use iroha-ubuntu-latest Valid sign-off found
🟢 ea490d6 use self-hosted Valid sign-off found
🟢 8843250 use iroha-ubuntu-latest Valid sign-off found
🟢 3958d33 try loop Valid sign-off found
🟢 a54705d try loop 2 Valid sign-off found
🟢 951f76b try loop 3 Valid sign-off found
🟢 f0942de try loop 4 Valid sign-off found
🟢 00a28b4 try loop 5 Valid sign-off found
🟢 3e3b60b try loop 6 Valid sign-off found
🔴 e955b76 testCoverage + sonar Sign-off not found
🔴 0289622 fixup! testCoverage + sonar Sign-off not found
🔴 314e6ae try global task dep Sign-off not found
🔴 0990629 ridiculous stupidity Sign-off not found
🔴 f57160d formatting Sign-off not found
🔴 5d1922c rollback global tasks dep Sign-off not found
🟢 1d1a3b0 try self-hosted runner Valid sign-off found
🔴 e12e4ee bumped testcontainers version Sign-off not found
🔴 76541ca more stupid configs Sign-off not found
🔴 abfefcf Sonar tweaks Sign-off not found
🔴 57fcc96 More attempts Sign-off not found
🟢 622a340 add sonar base branch Valid sign-off found
🟢 c960deb add sonar base branch fix typo Valid sign-off found
🟢 16e88d5 add sonar base add pr key Valid sign-off found
🟢 f87a976 add sonar base add pr key 2 Valid sign-off found
🟢 275495d add sonar base add pr key 3 Valid sign-off found
🟢 119f14f other runner Valid sign-off found
🟢 249c612 use self-hosted Valid sign-off found
🟢 3848c0e remove params Valid sign-off found
🟢 3243d9b try sonar on push Valid sign-off found
🟢 5a5fb77 try sonar on push Valid sign-off found
🟢 a8ff45f try sonar on push Valid sign-off found
🟢 d1ef171 try sonar on push Valid sign-off found
🟢 b85056d try sonar on push Valid sign-off found
🟢 ff81235 try sonar on push Valid sign-off found
🟢 3d5b5ea try sonar on push Valid sign-off found
🟢 2a5a88b try sonar on push Valid sign-off found
🟢 b2b2016 ci: try sonar-scanner Valid sign-off found
🟢 f37320b ci: try sonar-scanner Valid sign-off found
🟢 d18ea2d ci: try sonar-scanner Valid sign-off found
🟢 0ec39ca ci: try sonar-scanner Valid sign-off found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~42 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin feature/DOPS-3309/sonar-dojo