Skip to content

Commit

Permalink
Merge pull request #11 from synaphea/master
Browse files Browse the repository at this point in the history
Propose mirgration of codebase from JS to TS
  • Loading branch information
takemiyamakoto authored Mar 22, 2017
2 parents b8a8044 + ac8a5b1 commit c12b0e4
Show file tree
Hide file tree
Showing 22 changed files with 5,809 additions and 330 deletions.
47 changes: 47 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"projectName": "iroha-javascript",
"projectOwner": "GUCCI-swallow",
"files": [
"README.md"
],
"imageSize": 100,
"commit": true,
"contributors": [
{
"login": "takemiyamakoto",
"name": "",
"avatar_url": "https://avatars3.githubusercontent.com/u/20982317?v=3&s=460",
"profile": "https://github.com/takemiyamakoto",
"contributions": [
"code"
]
},
{
"login": "luca3104",
"name": "Satoshi Kaji",
"avatar_url": "https://avatars0.githubusercontent.com/u/12592891?v=3&s=460",
"profile": "https://github.com/luca3104",
"contributions": [
"doc"
]
},
{
"login": "6londe",
"name": "6londe",
"avatar_url": "https://avatars0.githubusercontent.com/u/11345397?v=3&s=460",
"profile": "https://github.com/6londe",
"contributions": [
"doc"
]
},
{
"login": "theofilis",
"name": "George Theofilis",
"avatar_url": "https://avatars3.githubusercontent.com/u/475517?v=3&s=460",
"profile": "https://github.com/theofilis",
"contributions": [
"code", "test", "tool"
]
}
]
}
11 changes: 11 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"presets": [
["env", {
"targets": {
"browsers": ["last 2 versions", "safari >= 7"],
"node": true
},
"modules": false
}]
]
}
27 changes: 27 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
version: 2

jobs:
build:
working_directory: ~/iroha-javascript
docker:
- image: node:7.7
steps:
- checkout
- restore_cache:
key: irohajs-{{ .Branch }}-{{ checksum "package.json" }}
- run:
name: Pre-Dependencies
command: mkdir ~/iroha-javascript/artifacts
- run:
name: Install Dependencies
command: npm prune && npm cache clean && npm install
- run:
name: Test & Build
command: npm run test:prod && npm run build
- store_artifacts:
path: ~/iroha-javascript/dist
destination: iroha
- save_cache:
key: irohajs-{{ .Branch }}-{{ checksum "package.json" }}
paths:
- "~/iroha-javascript/node_modules"
51 changes: 7 additions & 44 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,46 +1,9 @@
# Created by https://www.gitignore.io/api/node

### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
node_modules
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

dist
.DS_Store
*.log
.vscode
.idea
/dist/
.awcache
139 changes: 117 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
```html
<script src="/path/to/iroha.js"></script>
```
or
```js
import Iroha from 'iroha.js'
var Iroha = require('iroha.js')
```

### API
#### iroha.createKeyPair
Expand All @@ -35,6 +30,8 @@ var Iroha = require('iroha.js')
var keys = iroha.createKeyPair();
```



Return key object.
**Response**:

Expand All @@ -44,23 +41,19 @@ Return key object.
privateKey: A 64 byte private key encoded base64
}
```
#### iroha.sign
#### iroha.createSignature

```js
var signature = iroha.sign({
publicKey: A 32 byte public key encoded base64,
privateKey: A 64 byte private key encoded base64,
message: A message
});
var keys = iroha.createSignature();
```



Return signature object.
**signature**:
Return key object.
**keys**:

```js
//signature
//keys
{
publicKey: A 32 byte public key encoded base64,
privateKey: A 64 byte private key encoded base64,
Expand All @@ -74,19 +67,121 @@ signature(A signature string encoded base64)
#### iroha.verify

```js
var keys = iroha.verify({
publicKey: A 32 byte public key encoded base64,
signature: A signature,
message: A message
});
var keys = iroha.verify();
```


Return key object.
**keys**:

```js
//keys
{
publicKey: A 32 byte public key encoded base64,
signature: A signature,
message: A message
}
```
**Response**:

Return True or False;

## Author
[GUCCI-swallow](https://github.com/GUCCI-swallow)
### Development Guide

#### Features

- Zero-setup. After running `npm install` things will be setup for you :wink:
- **[Webpack 2](https://webpack.js.org/)** for UMD bundle, with [Tree-shaking](https://webpack.js.org/guides/tree-shaking/) dead code elimination
- Tests, coverage and interactive watch mode using **[Jest](http://facebook.github.io/jest/)**
- **[TSLint](https://palantir.github.io/tslint/)** ([standard-config](https://github.com/blakeembrey/tslint-config-standard)) for your code styling
- **Docs automatic generation and deployment** to `gh-pages`, using **[TypeDoc](http://typedoc.org/)**
- Automatic types `(*.d.ts)` file generation
- **[Travis](https://travis-ci.org)** integration and **[Coveralls](https://coveralls.io/)** report
- (Optional) **Automatic releases and changelog**, using [Semantic release](https://github.com/semantic-release/semantic-release), [Commitizen](https://github.com/commitizen/cz-cli), [Conventional changelog](https://github.com/conventional-changelog/conventional-changelog) and [Husky](https://github.com/typicode/husky) (for the git hooks)

#### NPM scripts

- `npm t`: Run test suite
- `npm run test:watch`: Run test suite in [interactive watch mode](http://facebook.github.io/jest/docs/cli.html#watch)
- `npm run test:prod`: Run linting + generate coverage
- `npm run build`: Bundles code, create docs and generate typings
- `npm run build:dev`: Same than `build`, but code is not minified
- `npm run commit`: Commit using conventional commit style ([husky](https://github.com/typicode/husky) will tell you to use it if you haven't :wink:)

#### Automatic releases

If you'd like to have automatic releases with Semantic Versioning, follow these simple steps.

_**Prerequisites**: you need to create/login accounts and add your project to:_
- npm
- Travis
- Coveralls

Set up the git hooks (see [Git hooks section](#git-hooks) for more info):

```bash
node tools/init-hooks
```

Install semantic release and run it (answer NO to "Generate travis.yml").

```bash
npm install -g semantic-release-cli
semantic-release setup
# IMPORTANT!! Answer NO to "Generate travis.yml" question. Is already prepared for you :P
```

From now on, you'll need to use `npm run commit`, which is a convenient way to create conventional commits.

Automatic releases are possible thanks to [semantic release](https://github.com/semantic-release/semantic-release), which publishes your code automatically on github and npm, plus generates automatically a changelog. This setup is highly influenced by [Kent C. Dodds course on egghead.io](https://egghead.io/courses/how-to-write-an-open-source-javascript-library)

#### Git Hooks

By default, there are 2 disabled git hooks. You can enable them by running `node tools/init-hooks` (which uses [husky](https://github.com/typicode/husky)). They make sure:
- You follow a [conventional commit message](https://github.com/conventional-changelog/conventional-changelog)
- Your build is not gonna fail in [Travis](https://travis-ci.org) (or your CI server), since it's runned locally before `git push`

This makes more sense in combination of [automatic releases](#automatic-releases)

#### FAQ

##### Why using TypeScript and Babel?

In most cases, you can compile TypeScript code to ES5, or even ES3. But in some cases, where you use "functional es2015+ features", such as `Array.prototype.find`, `Map`, `Set`... then you need to set `target` to "es6". This is by design, since TypeScript only provides down-emits on syntactical language features (such as `const`, `class`...), but Babel does. So it's set up in a 2 steps build so you can use es2015+ features.

This should be transparent for you and you shouldn't even notice. But if don't need this, you can remove Babel from the build:
- Set target to "es5" or "es3" in `tsconfig.json`
- Remove `"useBabel": true` from `tsconfig.json`

More info in [https://github.com/Microsoft/TypeScript/issues/6945](https://github.com/Microsoft/TypeScript/issues/6945)

##### What if I don't want git-hooks, automatic releases or semantic-release?

Then you may want to:
- Remove `commitmsg`, `postinstall` scripts from `package.json`. That will not use those git hooks to make sure you make a conventional commit
- Remove `npm run semantic-release` from `.travis.yml`

##### What if I don't want to use coveralls or report my coverage?

Remove `npm run report-coverage` from `.travis.yml`

##### What is `npm install` doing the first time runned?

It runs the script `tools/init` which sets up everything for you. In short, it:
- Configures webpack for the build, which creates the umd library, generate docs, etc.
- Configures `package.json` (typings file, main file, etc)
- Renames main src and test files

## Credits

Made with :heart: by [GUCCI-swallow](https://github.com/GUCCI-swallow) and all these wonderful contributors ([emoji key](https://github.com/kentcdodds/all-contributors#emoji-key)):

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
| [<img src="https://avatars3.githubusercontent.com/u/20982317?v=3&s=460" width="100px;"/><br /><sub>誠</sub>](https://github.com/takemiyamakoto)<br />[💻](https://github.com/GUCCI-swallow/iroha-javascript/commits?author=takemiyamakoto) | [<img src="https://avatars0.githubusercontent.com/u/12592891?v=3&s=460" width="100px;"/><br /><sub>Satoshi Kaji</sub>](https://github.com/luca3104)<br />[📖](https://github.com/GUCCI-swallow/iroha-javascript/commits?author=luca3104) | [<img src="https://avatars0.githubusercontent.com/u/11345397?v=3&s=460" width="100px;"/><br /><sub>6londe</sub>](https://github.com/6londe)<br />[📖](https://github.com/GUCCI-swallow/iroha-javascript/commits?author=6londe) | [<img src="https://avatars3.githubusercontent.com/u/475517?v=3&s=460" width="100px;"/><br /><sub>George Theofilis</sub>](https://github.com/theofilis)<br />[💻](https://github.com/GUCCI-swallow/iroha-javascript/commits?author=theofilis) [⚠️](https://github.com/GUCCI-swallow/iroha-javascript/commits?author=theofilis) 🔧 |
| :---: | :---: | :---: | :---: |
<!-- ALL-CONTRIBUTORS-LIST:END -->

This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Contributions of any kind welcome!

## License

Expand All @@ -102,4 +197,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
16 changes: 0 additions & 16 deletions gulpfile.js

This file was deleted.

Loading

0 comments on commit c12b0e4

Please sign in to comment.