Add helm-charts for explorer-db & explorer #353
Conversation
vineethboppudi
force-pushed
the
helm-charts
branch
from
875038a
to
f454267
Compare
vineethboppudi
requested review from
adityajoshi12
and removed request for
arsulegai
Signed-off-by: vineeth2328 <vineethboppudi23@gmail.com>
vineethboppudi
force-pushed
the
helm-charts
branch
from
f454267
to
4998ea4
Compare
| {{- toYaml .Values.annotations | nindent 6 }} | ||
| data: | ||
|
|
||
| test-network.json: |- |
There was a problem hiding this comment.
can we rename it something more meaningful?
| app: {{ .Release.Name }}-app | ||
| ports: | ||
| - port: {{ .Values.explorer.service.port }} | ||
| targetPort: {{ .Values.explorer.service.port }} |
There was a problem hiding this comment.
targetPort is the port on which explorer will be running internally, and to use the custom value for it, we also need the explorer to run on the same port. Can you check once if we can run explorer on the custom port.
There was a problem hiding this comment.
By default explorer port running on 8080. if we want to use custom value for targetPort like 9090. we need to add
PORT: 9090 in env of explorer.
There was a problem hiding this comment.
can you check if this property is available in the configmap
There was a problem hiding this comment.
Not their In current configmap. if want I can update
There was a problem hiding this comment.
if we are updating the targetPort in the service then we need to add that, or the other way is to keep the value of target port to 8080
There was a problem hiding this comment.
Okay I'll update configmap & default value as 8080. is that fine?
Signed-off-by: vineeth2328 <vineethboppudi23@gmail.com>
Signed-off-by: vineeth2328 <vineethboppudi23@gmail.com>
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
| } | ||
| } | ||
| }, | ||
| "organizations": { |
There was a problem hiding this comment.
Something to improve upon later: One instance of Explorer can be used for multiple organizations. There can be a different user login session seeing altogether a different network configuration. This section shall be more flexible to handle that.
| "{{ .Values.network.mspid}}": { | ||
| "mspid": "{{ .Values.network.mspid}}", | ||
| "adminPrivateKey": { | ||
| "pem": "{{ .Values.network.adminPrivateKey}}" |
There was a problem hiding this comment.
Please load private key from either a secret store or create in-memory volume to load it from an external secret storage.
| DATABASE_HOST: {{ .Release.Name }}-db | ||
| DATABASE_DATABASE: {{ $.Values.db.database | default "fabricexplorer" }} | ||
| DATABASE_USERNAME: {{ $.Values.db.database_username | default "hppoc" }} | ||
| DATABASE_PASSWD: {{ $.Values.db.database_password | default "password" }} |
There was a problem hiding this comment.
Similar to the private key, the password parameter is sensitive, it shall be loaded in from a secret store.
| data: | ||
| DATABASE_DATABASE: {{ $.Values.db.name | default "fabricexplorer" }} | ||
| DATABASE_USERNAME: {{ $.Values.db.username | default "hppoc" }} | ||
| DATABASE_PASSWORD: {{ $.Values.db.password | default "password" }} |
There was a problem hiding this comment.
Kubernetes secrets is a better place to load the secret values such as password.
helm-charts/explorer/values.yaml
Outdated
| #Eg. peerurl: grpcs://peer0-org1:7051 | ||
| peerurl: | ||
| #Provide the adminPrivateKey | ||
| #Eg. adminPrivateKey: -----BEGIN PRIVATE KEY-----\nMIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgUH2s+pegkyjaef+X\nyYBBP52PANixdkt7+xRgTkVPQPahRANCAATChVh6QCmBtI4/6S93XfEj7EDlz0Tf\nISNDAB3rsyjj3T60QhRGczSQmFyEkx6nrrWNyXLsTe/gr4Cc0l//QKQp\n-----END PRIVATE KEY-----\n |
There was a problem hiding this comment.
Secret information, let us evaluate if an alternate option can be used.
Signed-off-by: Vineeth Boppudi <boppudi@Vineeths-MacBook-Air.local>
|
PR is of interest for bevel, we were exploring opt. to add helm charts. Is this being currently worked on ? |
What this PR does / why we need it:
This feature implements helm-charts for explorer-db & explorer
Which issue(s) this PR fixes:
Fixes #333
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: