added new method addVerificationMethod and some changes related to ke… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishwas1
reviewed
Jul 26, 2023
src/did/did.ts
Outdated
| this.context = [constant['DID_' + keyType].DID_BASE_CONTEXT]; | ||
| this.context = [ | ||
| constant['DID_' + keyType].DID_BASE_CONTEXT, | ||
| constant['DID_' + keyType].DID_KEYAGREEMENT_CONTEXT, |
There was a problem hiding this comment.
You should not take DID_KEYAGREEMENT_CONTEXT context here since you ar enot allowing keyagreement verrelationship
Vishwas1
reviewed
Jul 26, 2023
src/did/did.ts
Outdated
| this.context = [constant['DID_' + keyType].DID_BASE_CONTEXT]; | ||
| this.context = [ | ||
| constant['DID_' + keyType].DID_BASE_CONTEXT, | ||
| constant['DID_' + keyType].DID_KEYAGREEMENT_CONTEXT, |
There was a problem hiding this comment.
You should not take DID_KEYAGREEMENT_CONTEXT context here since you ar enot allowing keyagreement verrelationship
Vishwas1
reviewed
Jul 26, 2023
src/did/IDID.ts
Outdated
| @@ -31,6 +31,10 @@ export enum IClientSpec { | |||
| 'cosmos-ADR036' = 'cosmos-ADR036', | |||
| } | |||
|
|
|||
| export enum IKeyAgreementKeyType { | |||
There was a problem hiding this comment.
Do not use a new variable, keep it in IKeyType itself
Vishwas1
reviewed
Jul 26, 2023
src/did/did.ts
Outdated
| public async addVerificationMethod(params: { | ||
| did?: string; | ||
| didDocument?: Did; | ||
| type: IKeyType | IKeyAgreementKeyType; |
Vishwas1
reviewed
Jul 26, 2023
src/did/did.ts
Outdated
| ) { | ||
| throw new Error('HID-SSI-SDK:: Error: params.publicKeyMultibase is required to addVerificationMethod'); | ||
| } | ||
| const verificationMethod = {}; |
There was a problem hiding this comment.
use VerificationMethod type
import { VerificationMethod } from '../../libs/generated/ssi/did';
some small changes
Vishwas1
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…yAgreement type