added api call for generating access token and did #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishwas1
reviewed
Jul 24, 2023
src/ssiApi/apiAuth/apiAuth.ts
Outdated
| this.apiKey = apiKey | ||
| } | ||
| async generateAccessToken(): Promise<IgenerateToken> { | ||
| const studioApiUrl = "https://api.entity.hypersign.id/api/v1/app/oauth" |
There was a problem hiding this comment.
studioApiUrl should not be hardcoded here, put it in config
There was a problem hiding this comment.
ya i have added it in separate file now. Yet not commited
Vishwas1
reviewed
Jul 24, 2023
src/ssiApi/apiAuth/apiAuth.ts
Outdated
| const studioApiUrl = "https://api.entity.hypersign.id/api/v1/app/oauth" | ||
| const headers = { | ||
| "X-Api-Secret-Key": this.apiKey, | ||
| "Origin": "https://entity.hypersign.id" |
There was a problem hiding this comment.
Origin should not also be hardcoded, I guess you need to take this in constructor params
There was a problem hiding this comment.
No need of passing origin. Its working fine without passing origin also
Vishwas1
requested changes
Jul 24, 2023
| this.accessToken = accessToken.access_token | ||
| } | ||
| public async generateDid(params: IGenerateDid) { | ||
| const apiUrl = "https://api.entity.hypersign.id/api/v1/did/create" |
There was a problem hiding this comment.
this also should not be hardcoded here
| const headers = { | ||
| "Content-Type": "application/json", | ||
| Authorization: `Bearer ${this.accessToken}`, | ||
| Origin: "https://entity.hypersign.id" |
There was a problem hiding this comment.
Take this in constructor params
… getting correct error response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented api call from sdk to studio-api for creating, registering, resolving and updating a didDoc