-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix junit version #978
Fix junit version #978
Conversation
@@ -250,10 +250,10 @@ dependencies { | |||
implementation "org.unbescape:unbescape:1.1.6.RELEASE" | |||
implementation "org.slf4j:slf4j-api:1.7.25" | |||
|
|||
testImplementation 'junit:junit:4.12' | |||
testImplementation 'junit:junit:4.13' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest JUnit version is 4.13.2. Any particular reason you’re not updating to the latest version?
testImplementation "org.mockito:mockito-core:1.9.5" | ||
testImplementation "org.hamcrest:hamcrest-library:1.3" | ||
testImplementation "org.hamcrest:hamcrest-core:1.3" | ||
testImplementation "org.hamcrest:hamcrest-library:3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hamcrest isn’t being split up anymore. Both org.hamcrest:hamcrest-library
and org.hamcrest:hamcrest-core
are now basically empty JAR files that both depend on org.hamcrest:hamcrest
in order to get Maven and Gradle to do the right thing. We should cut out the middleman here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what branch did you base your pull request on? My gradle/verification-metadata.xml
already contains keys for both hamcrest and JUnit…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settings for your local IDE do not belong in version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not belong in this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks quite unrelated. Please don’t mix unrelated features in pull requests, that just makes it more confusing and more complicated to get anything done.
I re-forked the project, starting from scratch completely and from the "next" branch, the jar build is working:
But then the tests fail:
Creating another PR dedicated to that. |
Along with junit version upgraded to 4.13 (gradle test was failing) and hamcrest updated to 3.0, added Codespace config for easier dev onboarding.