Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TS and JSX shared configs from eslint-config-hypothesis #6616

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Oct 18, 2024

Replace some local eslint config with the one introduced in hypothesis/frontend-toolkit#54

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (25358a0) to head (7582b28).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6616   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         270      270           
  Lines       10175    10175           
  Branches     2419     2419           
=======================================
  Hits        10117    10117           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the same peer dependency issue as @hypothesis/frontend-shared with:

➤ YN0002: │ @typescript-eslint/type-utils@npm:8.9.0 [40670] doesn't provide eslint (p95211), requested by @typescript-eslint/utils

Otherwise LGTM.

@acelaya
Copy link
Contributor Author

acelaya commented Oct 18, 2024

There is the same peer dependency issue as @hypothesis/frontend-shared with:

➤ YN0002: │ @typescript-eslint/type-utils@npm:8.9.0 [40670] doesn't provide eslint (p95211), requested by @typescript-eslint/utils

Otherwise LGTM.

To be honest, I don't get this error. ESLint is there, provided by the root package.json, in the version that all those packages require 🤔

I have updated to latest typescript-eslint nonetheless, but I guess the "intermediary" packages also need to require eslint for yarn to be happy?

@acelaya acelaya merged commit 4805c34 into main Oct 18, 2024
4 checks passed
@acelaya acelaya deleted the shared-eslint-config branch October 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants