Skip to content

refactor: merge IexecERC20Base into IexecEscrowTokenFacet - #345

Merged
zguesmi merged 3 commits into
mainfrom
refactor/merge-token-contracts
Aug 31, 2026
Merged

refactor: merge IexecERC20Base into IexecEscrowTokenFacet#345
zguesmi merged 3 commits into
mainfrom
refactor/merge-token-contracts

Conversation

@zguesmi

@zguesmi zguesmi commented Aug 31, 2026

Copy link
Copy Markdown
Member

Merges the IexecERC20Base abstract contract into IexecEscrowTokenFacet, its only implementer.
The facet ABI is identical before and after.

Next step

Rename:

  • IexecEscrowTokenFacet -> IexecEscrowFacet
  • IexecEscrowToken (interface) -> IexecEscrow
  • IexecInterfaceToken -> IexecInterface

@zguesmi
zguesmi requested a review from Le-Caignec as a code owner August 31, 2026 09:50
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (26772eb) to head (8e3fa58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          32       31    -1     
  Lines        1095     1095           
  Branches      223      212   -11     
=======================================
  Hits         1090     1090           
  Misses          5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi
zguesmi merged commit 774d9dd into main Aug 31, 2026
8 checks passed
@zguesmi
zguesmi deleted the refactor/merge-token-contracts branch August 31, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants