Fix change report generation - #279
Merged
Merged
Conversation
…are handled correctly.
…iately add relevant filenames
🦋 Changeset detectedLatest commit: 6df991e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR fixes change report generation in changed-elements-react by improving property extraction from Presentation content (including nested/related content) and by refining how model source filenames are determined for the changed models report.
Changes:
- Deduplicates wanted Presentation fields and adds nested-content-aware display value extraction when populating report properties.
- Updates the Presentation stub ruleset used to fetch content descriptors/content for selected instances.
- Reworks the model source filename lookup query and adds a changeset for the patch release.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/changed-elements-react/src/api/ReportGenerator.ts | Improves property field selection/deduping and correctly reads display values from nested/related content for report population. |
| packages/changed-elements-react/src/api/ModelReportGenerator.ts | Refactors the ECSQL used to map models to source filenames via ExternalSourceAspect queries. |
| .changeset/tricky-rocks-heal.md | Adds a patch changeset describing the change report generation fixes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mattbjordan
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes related to change report generation: