Set a default width for rendering images so they don't get raw wdith #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorns
force-pushed
the
bjorns/set-image-width
branch
from
338dc87
to
b7b7f5e
Compare
bjorns
force-pushed
the
bjorns/set-image-width
branch
from
b7b7f5e
to
03bda22
Compare
bjorns
force-pushed
the
bjorns/set-image-width
branch
from
ac5b71f
to
219b9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #120
Currently images are rendered in default resolution when we push them to Confluence. For retina style screenshots for example this ends up unreadable in the final page. Here's an example:
This PR sets the correct namespace and a default width for all uploaded images equal to the 764px width of the confluence page text. The end result is a correctly scaled screenshot like in this example: