TestGit #28
Open
TestGit #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideadapt
reviewed
Nov 10, 2021
| class UserValidatorTest { | ||
|
|
||
| @Nested | ||
| class isValidUsername{ | ||
|
|
||
| @Test | ||
| void returnsTrueIfOnlyLetters(){ | ||
| throw new IllegalArgumentException("you should implement code here"); | ||
| //kein mokito |
There was a problem hiding this comment.
Die Idee all dieser isValidUsername Testfälle ist es, sicherzustellen, dass alle Szenarien (z.B. "OnlyLetters") von der Methode isValidUsername korrekt erkannt werden.
z.B. für den returnsTrueIfOnlyLetters Testfall könnten die Assertion sein: Assertions.assertFalse(new User(",,,,").isValidUsername()); Assertions.assertTrue(new User("abcdefg").isValidUsername());
Im Testfall selbst befindet sich keine if oder for Schlaufe. Dieser Validierungsalgorithmus muss in die User Klasse.
| } | ||
|
|
||
| @Test | ||
| void returnsTrueIfUsernameInDB(){ | ||
| throw new IllegalArgumentException("you should implement code here"); | ||
| void returnsTrueIfUsernameInDB(){ //Test ist immer grün, auch wenn irgend welcher Code gelöscht wird...?????????????????????????? |
There was a problem hiding this comment.
Klar ist der immer grün ;) Schau mal wo überall du auf deine mockDatabase zugreifst, und wo überall du darauf zugreifen solltest ;)
Mok/ Mokito noch offen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.